-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yaml] package kafka_clients 3.1.2 in Kafka Provider jar #32623
Conversation
Signed-off-by: Jeffrey Kinard <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32623 +/- ##
============================================
- Coverage 58.84% 58.83% -0.01%
+ Complexity 3091 3090 -1
============================================
Files 1130 1130
Lines 174044 174028 -16
Branches 3320 3321 +1
============================================
- Hits 102414 102391 -23
- Misses 68293 68301 +8
+ Partials 3337 3336 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Signed-off-by: Jeffrey Kinard <[email protected]>
R: @robertwb FYI - I am going a different direction and just packaging Kafka 3.1.2 in the provider JAR used by Beam YAML (the other PR keeps having new transitive issues and I don't think it will get in to 2.60) |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
R: @Abacn |
* [yaml] package kafka_clients 3.1.2 in Kafka Provider jar Signed-off-by: Jeffrey Kinard <[email protected]> * fix test failure Signed-off-by: Jeffrey Kinard <[email protected]> --------- Signed-off-by: Jeffrey Kinard <[email protected]>
Patch fix to include kafka client 3.1.2 in JAR that contains Kafka provider (used by Beam YAML) in case #32486 does not pass tests in time for 2.60 cut.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.